Repository navigation
fix(spec): an absent shift offset reaches no row, whatever the edge - #1185
Draft
FabianHofmann wants to merge 4 commits into
Draft
FabianHofmann wants to merge 4 commits into
FabianHofmann wants to merge 4 commits into
Conversation
Collaborator
Author
|
Note The following content was generated by AI.
Generated by Claude Code |
Merging this PR will not alter performance
Comparing Footnotes
|
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1184.
Note
The following content was generated by AI.
Changes proposed in this Pull Request
Where a per-entity
shiftoffset is absent, the shift is not defined there, so the row is absent for everyedgemode, dense and sparse._gather_by_offset: keep the absent offset as "not defined" instead of casting NaN to int.edge='wrap'no longer readsx[t=0], andedge=<number>no longer fills it._gather_in_groups: a fill lands only where the offset is defined, as it already did only where the member is in a group.test_an_absent_entity_offset_shifts_to_no_row:edge×within× dense/sparse. 6 of 8 cases fail on master;edge='wrap'withwithin=was already right.test/test_spec*.py: 638 passed, 6 skipped.ruffandmypyclean.Checklist
AGENTS.md).doc.doc/release-notes.mdof the upcoming release is included.