feat: compose Q10 map content from grouped traits - #887
Merged
allenporter merged 6 commits intoJul 21, 2026
Conversation
allenporter
requested changes
Jul 19, 2026
allenporter
approved these changes
Jul 21, 2026
allenporter
left a comment
Contributor
There was a problem hiding this comment.
Looks great, just a minor change nit -- perhaps you can remove in a follow up PR? Thank you!
| assert "q10-position" in cli.commands | ||
|
|
||
|
|
||
| def test_q10_map_dps_trait_is_private() -> None: |
Contributor
There was a problem hiding this comment.
Lets not test internal details like this, just exercise behavior through the "api" methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Q10 map integration on top of #885 with a small low-level/high-level trait boundary matching the three incoming data streams.
MapDpsTraitowns restricted-zone and virtual-wall DPS values and exposes their decoded overlays.MapContentTraitexplicitly depends on that DPS trait, retains the latest map and trace packets, and calls the purerender_q10_mapfunction whenever renderable source data changes.MapDpsTraitwithout emitting a no-op high-level map notification.Q10PropertiesApiwires the DPS trait into both DPS fanout and the dependent map-content trait.The redundant path-specific CLI command from the staging stack is intentionally excluded, since normal
image_contentis already the single composed output. Trait tests cover source ownership and renderer handoff; calibration and pixel behavior remain in the map-module renderer tests.Validation
pre-commit run --show-diff-on-failure --color=always --all-filespytest -q— 796 passed, 86 snapshots passedStack