Skip to content

test: use mode enums for status codes - #888

Merged
allenporter merged 2 commits into
mainfrom
agent/use-mode-enums-in-status-tests
Jul 19, 2026
Merged

test: use mode enums for status codes#888
allenporter merged 2 commits into
mainfrom
agent/use-mode-enums-in-status-tests

Conversation

@Lash-L

@Lash-L Lash-L commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace raw fan power, water mode, and mop route status codes in container tests with the corresponding dynamic mode enum .code values
  • keep the assertions aligned with StatusV2's integer representation while making their meaning explicit

Validation

  • uv run --python 3.11 pytest tests/data/v1/test_v1_containers.py -q (31 passed)
  • uv run --python 3.11 ruff check tests/data/v1/test_v1_containers.py
  • uv run pytest tests/data/v1/test_v1_containers.py on Python 3.14 (31 passed)

A repository-wide run on Windows reaches an existing Python 3.14 asyncio selector failure in tests/e2e/test_device_manager.py; the Linux CI matrix provides the authoritative full-suite result.

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
tests/data/v1/test_v1_containers.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lash-L
Lash-L marked this pull request as ready for review July 19, 2026 19:10
@Lash-L
Lash-L requested review from allenporter and Copilot July 19, 2026 19:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Lash-L

Lash-L commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

Updating the enums to make it a bit more understandable!

@allenporter
allenporter merged commit 41b94bd into main Jul 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants