Skip to content

CI: stop masking a failing notebook build #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmcky merged 1 commit into from
Jul 24, 2026
+6 −0
Merged

CI: stop masking a failing notebook build #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ jobs:
- name: Build Download Notebooks (sphinx-tojupyter)
shell: bash -l {0}
run: |
# `shell: bash -l {0}` is a custom shell spec, so GitHub does not inject
# `-eo pipefail` (it only does that for the bare `shell: bash` shorthand).
# Without this, a failing `jb build` would be masked by the trailing
# mkdir/cp, whose exit code becomes the step's — and `--keep-going`
# guarantees the .ipynb files exist for `cp` to succeed on.
set -eo pipefail
jb build lectures --path-output ./ --builder=custom --custom-builder=jupyter -n -W --keep-going
mkdir -p _build/html/_notebooks
cp -u _build/jupyter/*.ipynb _build/html/_notebooks
Expand Down
Loading