chore: pin QPK 5d4 in HK strategy - #116
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a2155e3a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dependencies = [ | ||
| "pandas>=2.0", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@230854059c11a3711fed4bd997e3f8a7f37cba32", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@5d4bbd0e7ef9a1434010e8b6a69905d39ee55f1b", |
There was a problem hiding this comment.
In .github/workflows/ci.yml:67-72, CI runs QPK's check_qpk_pin_consistency.py with --pin-file external/QuantPlatformKit/QPK_PIN; I checked QuantPlatformKit at 5d4bbd0e7ef9... and current main, and that QPK_PIN still contains 230854059c11.... For pushes/PRs where the workflow checks out QPK main or this 5d4 commit, this new manifest pin is therefore reported as a mismatch in pyproject.toml/uv.lock and the required CI job exits before tests run; keep the manifests on 230854... until QPK_PIN advances, or advance QPK_PIN with the pin.
Useful? React with 👍 / 👎.
1 participant
Frozen QPK 5d4 pin candidate.
1a2155e3a48a212e062f0584f6982f2f2b40d955pyproject.toml,qsl.toml,uv.lock