Skip to content

ci: guard downstream QPK pin writers #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Aug 4, 2026
Merged

ci: guard downstream QPK pin writers #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/open-downstream-qpk-pin-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
name: Open Downstream QPK Pin PRs

on:
push:
branches: [ main ]
paths:
- "QPK_PIN"
- "qsl-pins.txt"
- "constraints.txt"
workflow_dispatch:

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict downstream dispatches to main

Now that the main-branch push trigger was removed, the only path to this writer is workflow_dispatch, but the job no longer restricts the selected ref. GitHub's manual-run docs expose a Branch selector / gh workflow run --ref BRANCH (https://docs.github.com/actions/managing-workflow-runs/manually-running-a-workflow), and actions/checkout checks out the event ref by default (https://github.com/actions/checkout#usage); if a maintainer dispatches this from a feature branch or tag, scripts/open_downstream_qpk_pin_prs.py reads that ref's QPK_PIN and opens PRs in every downstream repo for a pin that may never have landed on main. Add a job-level if: github.ref == 'refs/heads/main' or checkout main explicitly before using QSL_REPO_SYNC_TOKEN.

Useful? React with 👍 / 👎.


permissions:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/update-qpk-pin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
- "QPK_PIN"
- "qsl-pins.txt"
- "constraints.txt"
- ".github/workflows/open-downstream-qpk-pin-prs.yml"
- ".github/workflows/update-qpk-pin.yml"
- "docs/**"
- "**.md"

Expand Down