Skip to content

fix: persist negative SOXL promotion evidence - #236

Merged
Pigbibi merged 2 commits into
mainfrom
codex/qsl-p3-soxl-negative-evidence-persistence-20260806
Aug 6, 2026
Merged

fix: persist negative SOXL promotion evidence#236
Pigbibi merged 2 commits into
mainfrom
codex/qsl-p3-soxl-negative-evidence-persistence-20260806

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • persist a digest-bound promotion-research-result.v1.json before fail-closed rejection
  • keep lifecycle claims non-promoted and human acceptance unset
  • cover proxy-sensitive negative evidence and artifact digest bindings

Validation

  • regression RED: terminal artifact absent on accepted base
  • focused SOXL promotion/packager tests: pass
  • Ruff 0.15.9: pass
  • compileall and diff check: pass

No provider, runtime, deploy, paper, shadow, live, order, or capital path changes.

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b566895fb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/us_equity_snapshot_pipelines/lifecycle/soxl_promotion_runner.py Outdated
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit bb8d573 into main Aug 6, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the codex/qsl-p3-soxl-negative-evidence-persistence-20260806 branch August 6, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant