Add request-bound SOXL error 321 classifier - #239
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c272b653fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert provider_end_time in { | ||
| CUTOFF.strftime("%Y%m%d %H:%M:%S UTC"), | ||
| CUTOFF.strftime("%Y%m%d-%H:%M:%S"), | ||
| } |
There was a problem hiding this comment.
When validating the two accepted IBKR end-time representations, this assertion only checks each hard-coded parameter against the same two locally formatted constants; provider_end_time is never passed through or captured from the code under test. Both parameterized runs therefore exercise identical behavior, and the test would still pass if the provider serialization emitted an invalid third format, leaving the error-321 scenario it advertises untested.
Useful? React with 👍 / 👎.
1 participant
Fresh-base replacement for closed-unmerged #238.
No provider calls, credentials, bars, backtests, promotion, or runtime changes.