Refactor to use babashka/cli for entrypoint args - #291
Merged
Conversation
…and add a fmt-fix task too
Quantisan
approved these changes
Jul 15, 2026
| filter-opts (dissoc opts :parallelism)] | ||
| (build-images (or parallelism 4) cfg/installer-hashes (generate-variants filter-opts)))) | ||
|
|
||
| (def cmd-table |
| :default 4 | ||
| :validate pos?}}}]) | ||
|
|
||
| (defn -main |
| (run {:cmd (if cmd (keyword cmd) :build-images) | ||
| :args args | ||
| :parallelization 4}))) | ||
| (defn run |
Owner
There was a problem hiding this comment.
stating obvious.. would be nicer if we can do away with this second entry point
The exec-fn based entrypoint was dead code left over from before the babashka.cli migration: bb.edn's build-images task already calls -main directly, and nothing else referenced clojure -X:build-images. It also silently dropped the :parallelization exec-arg, which never reached cmd-build-images's :parallelism option. Addresses review feedback on PR #291.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd been meaning to do this for awhile. Uses babashka/cli for processing entrypoint args.