Beast/block reward update - #42
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2aed434. Configure here.
| const minerReward = | ||
| minerTransfer?.amount ?? | ||
| (minerRewardFallback != null ? String(minerRewardFallback) : null); | ||
| const treasuryReward = treasuryTransfer?.amount ?? null; |
There was a problem hiding this comment.
Miner payout shown as treasury
Medium Severity
When minerRewards is empty so miner is undefined, splitRewardTransfers never picks a miner row and leaves every hashless reward transfer in treasuryTransfers. The UI then labels treasuryTransfers[0] as treasury reward, which can be the miner payout amount with no matching miner reward shown from transfers.
Reviewed by Cursor Bugbot for commit 2aed434. Configure here.
|
|
||
| const minerReward = | ||
| minerTransfer?.amount ?? | ||
| (minerRewardFallback != null ? String(minerRewardFallback) : null); |
There was a problem hiding this comment.
Partial miner reward fallback
Medium Severity
The miner reward fallback uses only minerRewards[0].reward, while other miner-reward views aggregate every row for the same block. Multiple miner_reward rows for one block understate the displayed miner reward when unified rewardTransfers lack a matching miner transfer.
Reviewed by Cursor Bugbot for commit 2aed434. Configure here.


Update miner and treasury reward display
Note
Medium Risk
Broad changes to how transaction counts and lists are computed (new filter predicate and different aggregate sources), so displayed totals and sparklines may shift; block reward UI depends on matching reward transfers to the miner by
toaddress.Overview
Block details now show separate miner and treasury reward amounts instead of a single block
reward, using hashlessIMMEDIATEunified_transactionrows (withminer_rewardas fallback for the miner amount).Transaction lists and metrics consistently omit hashless
IMMEDIATErows (treated as miner/treasury rewards) viaEXCLUDE_REWARD_TRANSFERS/withExcludedRewardTransfers. Home and unified-transaction stats switch fromtransfer_aggregate/ summedchain_statscounters to filteredunified_transaction_aggregatequeries, including a new all-time transaction count on the landing hero.Table and detail labels change Hash / ID to Hash only; schemas add
BlockRewardTransferand slim home stats types.Reviewed by Cursor Bugbot for commit 2aed434. Configure here.