refactor: centralize mnemonic generation in the SDK - #593
Merged
Conversation
MinerWalletService re-implemented SubstrateService.generateMnemonic() instead of calling it. Delegate to the SDK so all seed generation lives in one place, and reuse a single Random.secure() instance when filling the entropy buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Seed generation lived in two places:
SubstrateService.generateMnemonic()(used by the mobile and cold-wallet apps) and a duplicated copy inMinerWalletService. Duplicated entropy-generation code is a maintenance and audit risk — a future change to one path could silently diverge from the other.What
MinerWalletService.generateMnemonic()now delegates toSubstrateService().generateMnemonic(), so all mnemonic/seed generation lives in one spot inquantus_sdk.Random.secure()instance instead of constructing one per entropy byte (no behavior change — each instance was freshly OS-seeded anyway).Both paths were and remain OS-CSPRNG-backed (
Random.secure()→ SecRandomCopyBytes / getrandom / BCryptGenRandom); this is a consolidation, not a security fix.Verification
melos run format— cleanmelos run analyze— clean for quantus_sdk, miner-app, cold-wallet-app (mobile-app's analysis server crashes with SIGKILL on this machine, unrelated to this change; mobile-app is untouched)