Skip to content

Conclusiones y recomendaciones individuales de Julio Meza para el Entregable 3 del TP - #48

Merged
R0SEWT merged 1 commit into
developfrom
task/julio
Oct 2, 2026
Merged

R0SEWT merged 1 commit into
developfrom
task/julio

Conversation

@ElJulioGG

@ElJulioGG ElJulioGG commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Cambios realizados

  • Se añadieron las conclusiones y recomendaciones
    Archivo modificado
  • tp/informe/tp/secciones/conclusiones/julio.tex

Summary by Sourcery

Documenta las conclusiones y recomendaciones individuales de Julio Meza para el Entregable 3 del TP.

Enhancements:

  • Incorpora las conclusiones individuales sobre la corrección, sincronización y rendimiento de la implementación concurrente de K-means.

Documentation:

  • Añade las recomendaciones de Julio Meza para ampliar la cobertura de pruebas con distintas configuraciones de workers y bloques.

@sourcery-ai

sourcery-ai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Se incorporan las conclusiones y recomendaciones de Julio Meza para el Entregable 3, enfocadas en la corrección de la concurrencia de K-means, la validación de casos borde y el rendimiento según la carga de trabajo.

File-Level Changes

Change Details Files
Se reemplaza el marcador pendiente por conclusiones individuales sobre la implementación concurrente de K-means y recomendaciones para ampliar su validación.
  • Documenta aprendizajes sobre procesamiento único de puntos, reducción determinista y actualización de centroides tras la barrera.
  • Relaciona las pruebas de casos borde con la verificación mediante Spin para detectar órdenes de ejecución inválidos.
  • Analiza el speedup con distintas cantidades de workers y el costo de coordinación en datasets pequeños.
  • Recomienda probar más relaciones entre workers y bloques.
tp/informe/tp/secciones/conclusiones/julio.tex

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@R0SEWT R0SEWT left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisado: las cifras de speedup (3,80 / 5,82 / 6,25) coinciden con generado/cifras.tex y lo de 10.000 viajes con tp/docs/analisis-gpu.md. Fusiono en develop.

@R0SEWT
R0SEWT merged commit 6a6895e into develop Oct 2, 2026
4 checks passed
@R0SEWT
R0SEWT deleted the task/julio branch October 2, 2026 00:17
R0SEWT added a commit that referenced this pull request Oct 2, 2026
…nforme del TP

Cierra los \pendiente de la tabla de pull requests y de la participación del
Entregable 3 con lo que trae cada PR, y regenera el historial de commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants