Conversation
causten
requested review from
TedThemistokleous and
eddieliao
and
a lite review from Copilot
August 11, 2026 20:35
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eddieliao
approved these changes
Aug 11, 2026
TedThemistokleous
approved these changes
Aug 11, 2026
Member
|
The two mlir debug CI failures are not solved with my open g+g PR. I opened a ticket for the two failing modules here and let Justin know. |
Collaborator
|
This seems to be a regression in rocmlir as these tests are not failing with the previous commit in rocmlir. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5129 +/- ##
===========================================
- Coverage 93.26% 93.13% -0.13%
===========================================
Files 623 625 +2
Lines 33097 33252 +155
===========================================
+ Hits 30866 30967 +101
- Misses 2231 2285 +54 🚀 New features to boost your workflow:
|
Regressions detected 🔴 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly update from rocmlir