Skip to content

[net][lwip-dhcpd] Add missing <string.h> include in dhcp_server_raw.c - #11835

Open
JHB11Hinson wants to merge 1 commit into
RT-Thread:masterfrom
JHB11Hinson:fix/lwip-dhcpd-missing-string-header
Open

JHB11Hinson wants to merge 1 commit into
RT-Thread:masterfrom
JHB11Hinson:fix/lwip-dhcpd-missing-string-header

Conversation

@JHB11Hinson

@JHB11Hinson JHB11Hinson commented Sep 24, 2026 •

Copy link
Copy Markdown

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

components/net/lwip-dhcpd/dhcp_server_raw.c 使用了 memcmp()、memset()、strlen()、strncmp() 和 strchr(),但没有包含 <string.h>。在 C 中这些函数会被隐式声明为返回 int:在 64 位目标上,p = strchr(...) 会把 64 位指针截断为 32 位再赋给 char *,得到错误地址,属于未定义行为;开启 -Werror=implicit-function-declaration 时该文件还会直接编译失败。

The file calls memcmp(), memset(), strlen(), strncmp() and strchr() but does not include <string.h>. They are implicitly declared as returning int; on 64-bit targets the strchr() result is truncated when assigned to a char *, which is undefined behaviour.

你的解决方案是什么 (what is your solution)

在 libc 头文件区块加入 #include <string.h>,与仓库内其它 net 组件(如 components/net/netdev/src/netdev.c、components/net/lwip/port/ethernetif.c)保持一致。

Add #include <string.h> to the libc header block, consistent with other net components in the tree.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/w60x(仅用于编译验证;该 BSP 使能 RT_USING_LWIP + LWIP_USING_DHCPD,对应 dhcp_server_raw.c 分支)
  • .config: RT_USING_LWIP、LWIP_USING_DHCPD(lwip 2.0.3)
  • action: 本地使用 bsp/w60x/rtconfig.h + lwip-2.0.3 头文件,对 dhcp_server_raw.c 单文件做编译验证(host gcc,-Werror=implicit-function-declaration):修复前 10 处 implicit declaration、退出码 1;修复后 0 处、退出码 0。未做完整板级构建,CI 结果为准。

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

dhcp_server_raw.c calls memcmp(), memset(), strlen(), strncmp() and
strchr() without including <string.h>. They are then implicitly declared
as returning int, which is undefined behaviour and, on 64-bit targets,
truncates the pointer returned by strchr() when assigned to a char *.
Include the missing standard header.
@CLAassistant

CLAassistant commented Sep 24, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix/lwip-dhcpd-missing-string-header
    Enter PR branch fix/lwip-dhcpd-missing-string-header in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/lwip-dhcpd-missing-string-header 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/lwip-dhcpd-missing-string-header branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/net/lwip-dhcpd/dhcp_server_raw.c

📊 Current Review Status (Last Updated: 2026-09-24 21:26 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants