Skip to content

[gd32][build] skip package precheck during gd32vw553h clean - #11837

Merged
Rbb666 merged 2 commits into
masterfrom
copilot/fix-riscv-none-job-failure
Sep 26, 2026
Merged

Rbb666 merged 2 commits into
masterfrom
copilot/fix-riscv-none-job-failure

Conversation

Copilot AI commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The riscv-none Actions job was failing in the GD32VW553H-EVAL BSP cleanup phase, not during compilation. scons -c still executed the BSP package availability check, so CI exited after successful build/dist steps when packages were no longer present.

  • Root cause

    • bsp/gd32/risc-v/gd32vw553h-eval/SConstruct registers bsp_pkg_check() as a pre-build action.
    • That check ran unconditionally, including for scons -c, making cleanup depend on fetched packages.
  • Change

    • Short-circuit bsp_pkg_check() when SCons is running in clean mode.
    • Keep the existing package guard intact for normal builds.
  • Impact

    • Cleanup no longer fails after CI build/dist flows remove or omit packages.
    • Build behavior is unchanged: missing required packages still stop real builds early.
  • Code

    def bsp_pkg_check():
        if GetOption('clean'):
            return
    
        need_update = not packages_available(os.path.abspath('.'), ['gd32-riscv-series-latest'])

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job riscv-none [gd32][build] skip package precheck during gd32vw553h clean Sep 25, 2026
Copilot AI requested a review from BernardXiong September 25, 2026 05:36
@github-actions github-actions Bot added BSP BSP: GD32 BSP related with GD32 labels Sep 25, 2026
@BernardXiong
BernardXiong marked this pull request as ready for review September 25, 2026 16:44
@Rbb666
Rbb666 merged commit b40aeb1 into master Sep 26, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants