Skip to content

fix(pull-requests): apply available tracking summaries to filters - #17

Open
kalvenschraut wants to merge 1 commit into
gitea/access-guardsfrom
gitea/tracking-filters
Open

fix(pull-requests): apply available tracking summaries to filters#17
kalvenschraut wants to merge 1 commit into
gitea/access-guardsfrom
gitea/tracking-filters

Conversation

@kalvenschraut

@kalvenschraut kalvenschraut commented Sep 5, 2026

Copy link
Copy Markdown
Member

PR check filters now apply the provider’s available check summary, fixing Gitea rows that previously remained visible under the opposite filter. Pending and known-empty summaries match neither passing nor failing; hosts without summaries retain their existing behavior. The Gitea decoder reuses the shared tracking schemas.

Focused service cases cover passing, failing, pending, empty, and unavailable summaries. Final integrated server typecheck and targeted lint pass.

Final stack validation at 256fd6fe5: 228 focused tests passed, followed by 61 API/workflow cases and the final team-recovery regression; server typecheck and targeted lint passed. The live settle-on-merge E2E previously passed with fixture cleanup. Companion Gitea backend and focused integration tests passed, including native revert across all five merge styles.

Model: GPT-5.6 Luna and GPT-6 Astra. Harness: Codex.

@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gitea/tracking-filters

Comment @coderabbitai help to get the list of available commands.

@kalvenschraut
kalvenschraut marked this pull request as ready for review September 5, 2026 05:57
@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai review

Please review this PR at its exact current head in stack pingdotgg#6. Verify correctness, regressions, security boundaries, and focused coverage against its current base, and report any actionable findings with file references.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== Current checkout =='
git status --short
git rev-parse HEAD
git branch --show-current

echo '== PR metadata =='
gh pr view 17 --repo RTVision/t3code --json number,title,headRefName,headRefOid,baseRefName,baseRefOid,commits,files,url

echo '== Current merge base and changed files =='
base_ref="$(gh pr view 17 --repo RTVision/t3code --json baseRefOid --jq .baseRefOid)"
merge_base="$(git merge-base HEAD "$base_ref" 2>/dev/null || true)"
printf 'base_ref=%s\nmerge_base=%s\n' "$base_ref" "$merge_base"
git diff --name-status "$merge_base"...HEAD
git diff --stat "$merge_base"...HEAD

echo '== File outlines for changed source and test files =='
git diff --name-only "$merge_base"...HEAD | while IFS= read -r file; do
  case "$file" in
    *.ts|*.tsx|*.js|*.jsx)
      echo "--- $file"
      ast-grep outline "$file" --items all 2>&1 || true
      ;;
  esac
done

Length of output: 24185


🏁 Script executed:

#!/bin/bash
set -euo pipefail

base="$(git merge-base HEAD "$(gh pr view 17 --repo RTVision/t3code --json baseRefOid --jq .baseRefOid)")"

echo '== Exact patch =='
git diff --find-renames --find-copies --unified=80 "$base"...HEAD -- \
  apps/server/src/pullRequest/GiteaPullRequestApi.ts \
  apps/server/src/pullRequest/PullRequestService.ts \
  apps/server/src/pullRequest/PullRequestService.test.ts \
  packages/contracts/src/pullRequest.ts

echo '== Summary schema and all summary producers/consumers =='
rg -n -C 6 --glob '*.ts' \
  '\bPullRequestProviderSummary\b|\bcheckSummary\b|\bchecksState\b|\bsummary:\s*(Option\.)?(none|some)\b' \
  apps packages

echo '== Changed service and Gitea context =='
sed -n '1,180p' packages/contracts/src/pullRequest.ts
sed -n '1660,1810p' apps/server/src/pullRequest/GiteaPullRequestApi.ts
sed -n '840,1060p' apps/server/src/pullRequest/PullRequestService.ts

echo '== Focused test context =='
rg -n -C 12 --glob 'PullRequestService.test.ts' \
  'checkSummary|checksState|passing|failing|pending|available' \
  apps/server/src/pullRequest/PullRequestService.test.ts

Length of output: 125941


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== Gitea list and search implementation =='
rg -n -C 10 --glob 'GiteaPullRequestApi.ts' \
  'function listPullRequests|const listPullRequests|includeTracking|listPullRequests\(|searchPullRequests|matchesPullRequest' \
  apps/server/src/pullRequest/GiteaPullRequestApi.ts
rg -n -C 10 --glob 'GiteaPullRequestProvider.ts' \
  'listChangeRequests|giteaToChangeRequest|includeTracking|filters' \
  apps/server/src/pullRequest/GiteaPullRequestProvider.ts
rg -n -C 8 --glob 'GiteaSearch.ts' \
  'includeTracking|search|filters' \
  apps/server/src/pullRequest/GiteaSearch.ts

echo '== Service list: filter, pagination, cache =='
rg -n -C 12 --glob 'PullRequestService.ts' \
  'matchesRowFilters|toEntry\(|nextListCursor|truncated:|ListCache|listCache|Cache.make|input\.filters' \
  apps/server/src/pullRequest/PullRequestService.ts

echo '== Test helpers and cache configuration =='
sed -n '120,290p' apps/server/src/pullRequest/PullRequestService.test.ts
sed -n '1020,1210p' apps/server/src/pullRequest/PullRequestService.ts

echo '== Exact changed lines with line numbers =='
git diff --unified=0 "$(git merge-base HEAD "$(gh pr view 17 --repo RTVision/t3code --json baseRefOid --jq .baseRefOid)")"...HEAD -- \
  apps/server/src/pullRequest/GiteaPullRequestApi.ts \
  apps/server/src/pullRequest/PullRequestService.ts \
  apps/server/src/pullRequest/PullRequestService.test.ts \
  packages/contracts/src/pullRequest.ts

Length of output: 57243


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '== Exact-head confirmation =='
printf 'checked_out='
git rev-parse HEAD
printf 'pr_head='
gh pr view 17 --repo RTVision/t3code --json headRefOid --jq .headRefOid

echo '== Patch consistency =='
base="$(git merge-base HEAD "$(gh pr view 17 --repo RTVision/t3code --json baseRefOid --jq .baseRefOid)")"
git diff --check "$base"...HEAD
git status --short

Length of output: 683


@kalvenschraut Reviewed PR #17 at current head d41838efd1fe8341cc3a8a9216e6f14ab150f6dd against stack base dfd06aec5894829f715dac7d8584f62bfe7588c4.

No actionable findings.

The Gitea provider requests tracking data for list and search paths. The service preserves the required distinction between unavailable summaries (undefined), known-empty summaries (null), pending summaries, and passing or failing summaries. The list-cache key includes the check filter. The focused service test covers all five states. The patch does not change authorization or repository-path security boundaries. git diff --check passed.

You are interacting with an AI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant