ci: drop the Linux build dependencies that are never used - #11
Open
ayozetr wants to merge 1 commit into
Open
Conversation
The Linux job installed libgtk-3-dev, libxdo-dev, libayatana-appindicator3-dev and pkg-config, and the README asked contributors to install the same three. None are reachable from a Linux build: `tray-icon`, the crate that wants libxdo and the app indicator, is declared under `[target.'cfg(windows)'.dependencies]`, and `rfd` resolves file dialogs through the XDG desktop portal over D-Bus, so `ashpd` is the only relevant crate in the tree and no `*-sys` crate looks for GTK. The built binary confirms it: it links libc, libm and libgcc_s and nothing else. Verified by building the release profile in a rust:1-slim-bookworm container with none of the four packages present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux job installs
libgtk-3-dev,libxdo-dev,libayatana-appindicator3-devandpkg-config, and the README asks contributors for the same three. None are reachable from a Linux build:tray-icon, the crate that wants libxdo and the app indicator, is declared under[target.'cfg(windows)'.dependencies].rfdresolves file dialogs through the XDG desktop portal over D-Bus, soashpdis the only relevant crate in the tree and no*-syscrate looks for GTK.The built binary agrees: it links
libc,libmandlibgcc_s, nothing else.Verified by building the release profile and running
cargo testin arust:1-slim-bookwormcontainer with none of the four packages installed; both complete. Context in #8.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.