Install shaderc with package manager in Linux CI workflow - #512
Merged
Conversation
patowen
force-pushed
the
linux-ci-no-shaderc
branch
2 times, most recently
from
August 9, 2026 14:11
de6fe2f to
dd76b05
Compare
patowen
marked this pull request as ready for review
August 9, 2026 14:22
Ralith
approved these changes
Aug 9, 2026
patowen
changed the title
patowen
force-pushed
the
linux-ci-no-shaderc
branch
from
August 10, 2026 00:06
dd76b05 to
4cddd57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the package.yml workflow for Linux uses the package manager to install Vulkan. I decided to replicate this setup for CI, as well as getting it to install shaderc.
This seems to work properly, as the unit tests pass. I also realize that the shaderc issues in package.yml were for Ubuntu 20.04, and we have since upgraded to 22.04, so it would probably make sense to install a pre-built version of shaderc there as well.
When I had tested with more verbose output in https://github.com/Ralith/hypermine/actions/runs/31316952178/job/93253646075 (using command
cargo build --workspace --all-targets --locked -vv 2>&1 | grep --line-buffered "shaderc\|Compiling"), I got the following:The build log did not mention it was building from source, so I think we are good on that front.