Skip to content

fix workspace manage experiments -i - #1923

Open
rfbgo wants to merge 2 commits into
Ramble-Project:developfrom
rfbgo:fix_manage_exp_defaults
Open

rfbgo wants to merge 2 commits into
Ramble-Project:developfrom
rfbgo:fix_manage_exp_defaults

Conversation

@rfbgo

@rfbgo rfbgo commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

There was an accidental regression and this no longer works:

    ramble workspace manage experiments gromacs --wf water_bare -i

immediately dies with:

    AttributeError: 'generator' object has no attribute 'variables'

Adds the missing test to prevent the break in the future

Signed-off-by: Bob <robertbird@google.com>
@rfbgo
rfbgo requested a review from linsword13 November 13, 2026 14:53
@rfbgo rfbgo changed the title fix workspace manage experiments -i fix workspace manage experiments -i Nov 13, 2026
@ramble-project-pr-bot

ramble-project-pr-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: a723b99

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 0.3646 0.3629 (f13ee91) 0.3654
test_large_template_expansion passed 1.0628 1.0707 (f13ee91) 1.2150
test_many_experiments passed 17.3281 17.2929 (f13ee91) 17.1959
test_many_objects_defaults passed 13.0662 13.0835 (f13ee91) 12.9160
test_matrix_filter_perf passed 0.9023 0.9036 (f13ee91) 0.8931

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/ramble/ramble/workspace/workspace.py 91.89% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Bob <robertbird@google.com>
@rfbgo
rfbgo force-pushed the fix_manage_exp_defaults branch from 02932a8 to a723b99 Compare November 13, 2026 15:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant