Repository navigation
hasEntitlement asks StoreKit every time instead of trusting a cached yes - #10
Merged
Merged
Conversation
A cached true could outlive the entitlement: a revocation StoreKit never announces through Transaction.updates, such as a cleared SKTestSession, left the product looking purchased for as long as the process ran. hasEntitlement(for:) now always reads Transaction.currentEntitlements and brings the cached flag into line in both directions, emitting PurchasedProductEvent only when a product becomes entitled. README asks for 3.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasEntitlement(for:)returned a cachedtruewithout asking StoreKit. That cache could outlive the entitlement when StoreKit revokes it without aTransaction.updatesevent — for example a clearedSKTestSession— so the product looked purchased for as long as the process ran. SnowWall's entitlement tests failed about one run in three because of it.Now
hasEntitlement(for:):Transaction.currentEntitlements;PurchasedProductEventonly when a product becomes entitled, likerefreshEntitlements().The public API is unchanged. The README asks for 3.1.1.
Testing:
swift testpasses (30 tests), and the library builds for macOS and visionOS on Xcode 27.