Repository navigation
feat(ui): 连接页可按应用分组,同一程序的连接收进可折叠的分组 - #152
Merged
Ray-lea merged 8 commits intoNov 22, 2026
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
页面栏新增“应用 / 列表”切换。按应用显示时,同一可执行文件的连接归入一个分组: 标题行显示图标、名称与连接数,默认折叠,单击箭头、双击、Enter 或方向键展开, 展开状态与所选视图会被记住。只有一个连接的程序仍显示为普通行;搜索时含匹配项的 分组自动展开。分组标题的右键菜单提供展开/折叠、转到进程与结束进程。
digital-bombyx
force-pushed
the
feat/connections-group-by-app
branch
from
November 21, 2026 11:09
d5815c7 to
4a1d4ab
Compare
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
Ray-lea
approved these changes
Nov 22, 2026
Ray-lea
left a comment
Owner
There was a problem hiding this comment.
已核对按路径分组和无路径时按文件名分组的回归测试。桌面模拟数据的 30 条连接折叠为 6 行,搜索自动展开 9 条匹配连接。两种绘制路径的 32 张截图逐像素一致,官网演示也通过折叠、展开和切回列表的检查。
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动概述 / Summary
连接页新增“按应用 / 列表”视图切换。按应用显示时,同一可执行文件的连接收进一个可折叠的分组,连接很多的程序(代理、浏览器)只占一行。
Adds an Apps / List view switch to the Connections page. In Apps view, connections of one executable fold under a single heading, so programs with many connections (proxies, browsers) take one row.
改动原因 / Motivation
连接列表按行平铺,一个程序可能占据大半个列表。例如本地代理 xray 有上百条 127.0.0.1:10808 的连接,其他程序被挤到很远,只能靠搜索或滚动查找。进程页已有按应用分组,连接页没有对应的视图。
The flat list lets one program fill most of it: a local proxy such as xray holds 100+ connections on 127.0.0.1:10808 and pushes every other program far down. The Processes page already groups by app; Connections had no such view.
改动思路 / Approach
分组在现有的排序、筛选、搜索与“隐藏系统进程”之后进行,仍在后台线程构建,因此筛选和排序语义不变。分组复用
Row已有的折叠字段(expandable/expanded/members/depth)以及名称单元格的箭头、缩进与计数徽标,不新增绘制代码。按规范化的可执行文件路径分组,路径缺失时按文件名分组。不同安装路径的同名程序分开显示。默认仍为“列表”视图,现有用户的界面不变。Grouping runs after the existing sort, filters, search and system-process hiding, still on the background thread, so their semantics are unchanged. It reuses
Row's fold fields and the name cell's chevron, indent and count badge — no new drawing code. Groups use the normalized executable path, falling back to the file name when the path is unavailable. Programs with the same name in different locations remain separate. The default stays List.改动明细 / Changes
lists.rs:ListSpec新增grouped、opened;group_connections按程序分组,分组按其第一条连接在当前排序中的位置排列,组内沿用列排序;只有一个连接的程序保持普通行。layout.rs/widgets.rs:连接页页面栏加入视图切换(复用shell.viewMode.*文案与图标)。backend.rs:Action::ConnectionView;Fold处理c:分组键并保存展开状态;Enter、双击与 ←/→ 折叠分组。menus.rs:分组行的右键菜单:展开/折叠、转到进程、结束进程(仅单个进程拥有时可用);分组行没有备注与置顶。tables.rs/cells.rs:连接页的分组行使用箭头、缩进与计数徽标;分组行不显示状态点。test_control.rs:新增connectionView测试控制。docs/guide/README.md(连接按应用分组、页面栏),docs/architecture/frontend.md(偏好键)。新增功能(可选)/ New features (optional)
connectionView)与展开的分组(openedConnectionApps)在重启后保留。影响与依赖 / Impact and dependencies
改动后界面截图 / UI screenshots
开发构建,实时数据,英文界面,深色主题,100% 缩放;进程描述为系统语言(俄文)。
Dev build, live data, English UI, dark theme, 100% scale; process descriptions follow the system language (Russian).
维护者复核
按维护者确认的规则,不同安装路径的同名程序分组显示,缺少路径时按文件名归组。新增路径归一化与缺失路径的回归测试。官网模拟数据的 15 条连接可折叠为 7 行;展开一组显示其中 5 条连接,切回列表恢复 15 行。官网 TypeScript 和多语言检查通过。
提交时验证 / Original validation
cargo build -p argus --bin argusdev.argus.taskmanager.test.conngroupscargo test -p argus --libgrouped_connections_fold_under_their_programs、a_program_with_several_processes_is_one_group_without_a_pidcargo clippy -p argus --all-targets -- -D warnings10808pnpm check(只改动src-gpui前端与文档);未核对浅色主题与小窗口。提交前检查 / Checklist
pnpm i18n/ N/A:复用现有的shell.viewMode.*,无新增文案THIRD-PARTY-NOTICES.txt/ N/A