Repository navigation
feat: 安装位置不在 Program Files 时,安装程序说明哪些文件仍在那里 - #154
Merged
Ray-lea merged 2 commits intoNov 22, 2026
Merged
Conversation
特权服务、管理员运行与内核传感器的文件以管理员或 SYSTEM 权限运行,无论安装到哪里都放在
只有管理员可写的 Program Files 中,否则普通用户可以替换它们来提升权限。选择其他文件夹安装时,
用户此前看不到这一点,误以为程序没有安装到所选位置。现在安装页的安装位置不在 Program Files
时,其下方显示一行说明,安装位置随之上移;默认位置的页面不变,更改位置后即时更新。
安装文案新增 {programFiles} 占位符($PROGRAMFILES64)。
Refs Ray-lea#136
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
安装位置不在 Program Files 时,不再在安装位置下方显示两行说明,改为在安装位置
文字之后显示信息图标(Segoe MDL2 Assets),指针悬停在图标或安装位置上时以提示
显示说明;路径较长时以省略号缩短,为图标留出位置。安装位置一行不再上移,页面
布局与默认位置相同。
说明改为“出于安全考虑,特权服务、管理员运行与内核传感器的文件仍存放在
{programFiles},仅在开启这些功能后创建。”,各语言同步修改。提示按页面宽度换行,
深色主题下使用深色样式,停留 30 秒。
Refs Ray-lea#136
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
Ray-lea
added a commit
that referenced
this pull request
Nov 22, 2026
Co-authored-by: bronyaicu <264752859+bronyaicu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动概述 / Summary
安装位置不在 Program Files 时,安装页在安装位置下方显示一行说明:特权服务、管理员运行与内核传感器的文件仍位于 Program Files。默认位置的页面不变。
When the install folder is outside Program Files, the install page shows a note under the location line: files for the privileged service, "Run as administrator" and kernel sensors stay in Program Files. The page is unchanged for the default folder.
改动原因 / Motivation
Refs #136
选择 D 盘等其他文件夹安装后,用户会在
C:\Program Files中看到Argus Privileged、Argus Runtime等文件夹,开启管理员运行时进程也从那里运行,因而以为程序没有安装到所选位置。这些组件以管理员或 SYSTEM 权限运行,必须放在只有管理员可写的目录,否则普通用户可替换它们来提升权限,所以不能移到安装目录;但安装时没有任何说明。复现:运行安装程序 → “更改” → 选择
D:\Argus。期望:页面说明哪些文件仍会位于 Program Files 及原因。改动思路 / Approach
只增加说明,不改变安装位置或组件的放置方式。说明仅在安装位置不在
$PROGRAMFILES64下时显示(不区分大小写的前缀比较),此时安装位置一行上移,说明占据其下方两行;默认位置的布局与之前完全相同,避免挤占主按钮周围的空间。路径不写死在文案中,用新的{programFiles}占位符在运行时取$PROGRAMFILES64。改动明细 / Changes
packaging/windows/installer-ui.nsh:安装页新增说明文本;ArgusPlaceNote按安装位置显示或隐藏说明,并移动安装位置与“更改”链接;更改位置后重新判断。locales/*/installer.json:8 种语言新增ArgusProgramFilesNote,术语沿用安装程序与设置页的现有译文(特权服务、管理员运行、内核传感器)。scripts/lib/installer-locales.mjs:新增占位符{programFiles}→$PROGRAMFILES64。影响与依赖 / Impact and dependencies
改动后界面截图 / UI screenshots
安装程序安装页,安装位置改为
F:\Argus;俄文系统语言,深色主题,100% 缩放。Installer page with the install folder changed to
F:\Argus; Russian system language, dark theme, 100% scale.验证 / Validation
renderInstaller与installerStrings生成,内含开发构建的argus.exe(仅查看页面,未执行安装)node scripts/i18n.mjsnode --test scripts/tests/installer-locales.test.mjs scripts/tests/bundle.test.mjs scripts/tests/locale-validation.test.mjsC:\Program Files\ArgusF:\Arguspnpm check与发布构建打包(改动限于安装程序界面与文案)。提交前检查 / Checklist
pnpm i18n/ Added or changed UI text covers all supported locales, follows the glossary and passespnpm i18n.THIRD-PARTY-NOTICES.txt/ N/A