Repository navigation
fix(uninstall): disable casaos-wsdd and casaos-local-storage-first too - #126
Merged
Merged
Conversation
Both are enabled by their setup scripts but were not in the uninstaller's list, so their symlinks in /etc/systemd/system stayed behind, pointing at removed unit files. With the recasaos* aliases a second symlink per unit would stay behind as well.
inkly
approved these changes
Nov 6, 2026
inkly
left a comment
inkly
left a comment
Collaborator
There was a problem hiding this comment.
Good catch: both units are enabled by their setup scripts, so they belong in the list.
Nit, no change needed: they land after casaos.service, whose comment says it "must be the last one". devmon@devmon.service already sits after it, so this changes nothing in practice.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
casaos-uninstalldisables the units in itsCASA_SERVICESlist.casaos-wsdd.serviceandcasaos-local-storage-first.serviceare enabled by their setup scripts but were missing from that list. After an uninstall, their symlinks in/etc/systemd/system/multi-user.target.wants/stayed behind, pointing at unit files the manifest had removed. With therecasaos*aliases (ReCasaOS/CasaOS#95, ReCasaOS/CasaOS-LocalStorage#26), a second symlink per unit would stay behind as well.On a box without one of them (an older release),
systemctl stopordisablefails and the uninstaller only says so, as it does for any unit in the list.About the
systemctl reenablestep from #84: it turned out not to be needed. The setup scripts already re-enable every unit on each update, and that adds a new alias; the details are in the CasaOS PR.Tested:
bash -n, andscripts/test-uninstall-modules.shunder dash ("all uninstall module checks passed").