Repository navigation
fix(account): the session that changes the password goes on with its new tokens - #175
Merged
Merged
Conversation
…tokens the change answers with A password change now ends every session of the account, the one that made it too, and the user service answers with the pair that session goes on with (ReCasaOS/CasaOS-UserService#13). The account panel stores it where the requests and the message bus read their token. An older user service answers with the user alone, and the session is left as it is.
inkly
marked this pull request as ready for review
November 10, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with ReCasaOS/CasaOS-UserService#13: a password change now ends every session of the account, the one that made the change too, and answers with the tokens that session goes on with.
The account panel stores those tokens where the requests read them (
localStorage) and where the message bus follows them (the store). Without this the person who changed their password was asked to sign in again when their token ran out, within three hours.A user service older than that answers with the user alone: the panel then leaves the session as it is.
Tests
src/components/account/AccountPanel.spec.js(new): the tokens of the answer are kept, and nothing is touched when the answer has none. The first failed before the change. The whole suite (8377 tests) and the lint of the two files pass. Not looked at in a browser.