Repository navigation
Fix: EPUB 업로드 트랜잭션 범위 축소 - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧑🏻💻 PR 작업 내역 요약
EPUB 업로드 시 S3 업로드와 EPUB 처리 같은 외부 I/O가 DB 트랜잭션 안에서 오래 실행되던 구조를 분리했습니다.
Closes #143
📋 변경 사항
BookService.uploadBook()를Propagation.NOT_SUPPORTED로 전환해 메서드 전체가 read-only 트랜잭션을 물지 않도록 했습니다.BookUploadTransactionService를 추가해 책 row 생성, artifact 반영, normalization job 생성, 실패 상태 반영만 짧은 DB 트랜잭션으로 처리합니다.FAILED로 남기는 보상 처리를 추가했습니다.dev를 병합하고, 충돌 해결 시CdnUrlService기반 표지 URL 변환을 함께 보존했습니다.BookServiceTest,BookUploadTransactionServiceTest로 호출 순서와 실패 보상 흐름을 검증했습니다.🔍 Code Review
FAILED로 남습니다.compileJava compileTestJava, 관련 서비스 테스트, 전체test를 모두 통과했습니다.📸 ScreenShot