Repository navigation
Feat: 관리자 도서 삭제 API 및 이미지 CDN URL 응답 적용 - #146
Merged
Merged
Conversation
7 of 9 tasks
ppp1969
marked this pull request as ready for review
July 14, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧑🏻💻 PR 작업 내역 요약
관리자 도서 단위 삭제 API를 추가하고, 프론트에 전달되는 공개 이미지 주소를 S3 원본 URL 대신 CloudFront/CDN URL로 정규화했습니다.
Closes #145
📋 변경 사항
DELETE /api/v2/admin/books/{bookId}를 추가했습니다.QUEUED또는PROCESSING상태의 처리 job이 있으면409 CONFLICT로 삭제를 거절합니다.CdnUrlService를 추가해 공개 object key와 설정된 버킷의 S3 URL을CLOUDFRONT_BASE_URL기반 URL로 변환합니다.검증 명령:
git diff --check./gradlew compileJava compileTestJava --no-daemon./gradlew test --tests com.kw.readwith.service.CdnUrlServiceTest --tests com.kw.readwith.service.AdminServiceTest --tests com.kw.readwith.service.BookServiceTest --tests com.kw.readwith.service.AdminImageGenerationServiceTest --tests com.kw.readwith.service.FineGraphServiceTest --tests com.kw.readwith.service.MacroGraphServiceTest --tests com.kw.readwith.service.RelationshipDeltaServiceTest --no-daemon./gradlew test --tests com.kw.readwith.controller.ApiRouteAliasMappingTest --no-daemon🔍 Code Review
public/*,character-images/*에 한정되고 외부 URL 및 비공개 key가 유지되는지 확인해주세요.CLOUDFRONT_BASE_URL이 올바른 CloudFront 또는 custom domain으로 설정되어야 합니다.R:\로subst한 뒤 테스트했습니다.📸 ScreenShot