Repository navigation
Docs: 관리자 삭제 및 이미지 후보 선택 Swagger 명세 보완 - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧑🏻💻 PR 작업 내역 요약
관리자 도서 삭제 API와 대표 후보 선택/fan-out API를 프론트엔드가 오해 없이 사용할 수 있도록 Swagger 명세를 보완했습니다.
Closes #147
📋 변경 사항
PROGRESS4001), 409(ADMIN4027) 응답을 Swagger에 명시했습니다.candidateId는referenceCandidates[].id에 담긴 asset DB ID임을 명시했습니다.slotNo1~4는 화면 표시용이며candidateId로 사용할 수 없다는 설명을 API 파라미터와 응답 DTO에 추가했습니다.AdminSwaggerDocumentationTest를 추가했습니다.🔍 Code Review
candidateId로CharacterImageAsset을 ID와 책 기준으로 조회하므로 asset DB ID 설명과 일치합니다../gradlew.bat test --tests com.kw.readwith.controller.AdminSwaggerDocumentationTest --no-daemon./gradlew.bat test --no-daemon📸 ScreenShot