Skip to content

Enable advisory template precalcuation - #2349

Merged
swadeley merged 1 commit into
RedHatInsights:masterfrom
swadeley:swadeley/HMS-11096
Sep 29, 2026
Merged

swadeley merged 1 commit into
RedHatInsights:masterfrom
swadeley:swadeley/HMS-11096

Conversation

@swadeley

@swadeley swadeley commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

HMS-11096: Turn on advisory template precalcuation in stage and test.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

Enable advisory template evaluation for stage and test workloads.

Enhancements:

  • Enable advisory template evaluation across listener and evaluator workloads in stage and test deployments.

Deployment:

  • Configure the listener, upload evaluator, recalculation evaluator, and user-evaluation services to use advisory template evaluation.

@sourcery-ai

sourcery-ai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The deployment manifest enables advisory template precomputation by setting template_advisory_eval=true for the listener and all evaluator service configurations, applying the feature across stage and test deployments.

File-Level Changes

Change Details Files
Enable advisory template evaluation through deployment configuration for all stage and test evaluator paths.
  • Set the listener configuration to enable template advisory evaluation.
  • Enable the same setting for upload, recalculation, and user-evaluation evaluator services.
deploy/clowdapp.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov-commenter

codecov-commenter commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (2cc96b3) to head (5353d22).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   58.95%   58.92%   -0.04%     
==========================================
  Files         150      150              
  Lines        9605     9605              
==========================================
- Hits         5663     5660       -3     
- Misses       3348     3351       +3     
  Partials      594      594              
Flag Coverage Δ
unittests 58.92% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swadeley
swadeley marked this pull request as ready for review September 28, 2026 20:06
@swadeley
swadeley requested a review from a team as a code owner September 28, 2026 20:06
sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Sep 28, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@sourcery-ai
sourcery-ai Bot dismissed their stale review September 29, 2026 09:26

Sourcery withdrew this approval because the latest commits introduced blocking findings.

HMS-11096: Turn on advisory template precalcuation in stage and test.
@swadeley
swadeley enabled auto-merge (squash) September 29, 2026 13:23
@swadeley
swadeley merged commit 5699848 into RedHatInsights:master Sep 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants