feat: Update VirtualMachineTemplateRequest with template_labels and ttl_seconds_after_finished#2771
feat: Update VirtualMachineTemplateRequest with template_labels and ttl_seconds_after_finished#2771RoniKishner wants to merge 1 commit into
Conversation
…tl_seconds_after_finished Signed-off-by: rkishner <rkishner@redhat.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
WalkthroughChangesVirtual machine template request
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ocp_resources/virtual_machine_template_request.py`:
- Around line 19-53: Regenerate the VirtualMachineTemplateRequest resource
instead of editing the generated class directly. Update the generator input
defining VirtualMachineTemplateRequest, then run class-generator with --kind
VirtualMachineTemplateRequest --overwrite --backup so the constructor and
documentation are recreated consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1fe685a4-b43d-44ff-a938-46b9f5f586ba
📒 Files selected for processing (1)
ocp_resources/virtual_machine_template_request.py
|
/verified |
Short description:
Update VirtualMachineTemplateRequest with template_labels and ttl_seconds_after_finished
More details:
Add 2 new fields in the VirtualMachineTemplateRequest class according to the CRD:
What this PR does / why we need it:
Update to the latest version.
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:
Summary by CodeRabbit