Repository navigation
Link benchmark pages by their clean URL, not a ?revision= copy - #47
Merged
Merged
Conversation
Every benchmark link named its revision, even the current one, and a page that named a revision was noindexed as a slice of the plain one. Crawlers therefore reached mostly noindexed copies, while the canonical pages were linked only from the sitemap. - Links leave ?revision= out when it names the current revision (benchmarkHref); a superseded revision is still named, and stays noindexed. - ?revision=<current> is no longer noindexed (isAlternateView): it is the same page, and the canonical already says so. The verified-only view and run pages still are. - The case, tool-report and run responses carry revision_is_current, since only the suite response said which revision is current.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A crawl showed most benchmark URLs as
noindex, follow. Every internal link named its revision, even the current one, for example/benchmarks/pdf/tools/redactable?revision=v0.1.1. Any page with a revision in its URL was noindexed as a slice of the plain page. So crawlers mostly reached noindexed copies, and the canonical pages were linked only from the sitemap.What changed
?revision=when it names the current revision (benchmarkHrefinlib/benchmarks/params.ts). That covers the leaderboard, case cards, the scope switch, the revision picker, and the links back from tool, case and run pages. Links to a superseded revision still name it.?revision=<current>is no longer noindexed (isAlternateView). It is the same page, and the canonical already says so. Superseded revisions,?scope=verifiedand run pages staynoindex, follow.revision_is_current, since previously only the suite response said which revision is current.openapi.jsonand the Orval client are regenerated.Test plan
make frontend-test: 908 passed. New tests coverbenchmarkHrefandisAlternateView, and each view's links for both current and superseded revisions.revision_is_current. These were run locally because CI skips most of them;benchmarks.ymlwill also run them, sinceapps/benchmarks/changed./benchmarks/pdfand/benchmarks/pdf?revision=v0.1.1are indexable,?scope=verifiedis noindexed, and the leaderboard links/benchmarks/pdf/tools/pdf-redaction.