Skip to content

RG-T127 Fixing TrackerGateway docker build - #441

Merged
ucswift merged 1 commit into
masterfrom
develop
Jul 28, 2026
Merged

RG-T127 Fixing TrackerGateway docker build#441
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Jul 28, 2026

Copy link
Copy Markdown
Member

PR Description

Fixes Docker build for TrackerGateway by ensuring dash shell is installed

This PR fixes a build issue (RG-T127) in the TrackerGateway Docker image where the LocalXpose CLI integration step was failing. The change:

  • Adds dash (the lightweight POSIX shell, default /bin/sh on Debian/Ubuntu) to the package installation step with the --reinstall flag to ensure it's present even if already in the base image
  • Adds a verification check (test -f /usr/bin/dash) to confirm the shell binary exists before proceeding to unzip the LocalXpose CLI

The fix ensures the required shell interpreter is available so the loclx binary can execute properly during the Docker build process.

@Resgrid-Bot

Resgrid-Bot commented Jul 28, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@request-info

request-info Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

TrackerGateway Docker build

Layer / File(s) Summary
Publish-stage shell setup
Workers/Resgrid.TrackerGateway/Dockerfile
The publish stage installs dash alongside unzip and verifies that /usr/bin/dash exists.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: github-actions

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: a TrackerGateway Docker build fix.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Workers/Resgrid.TrackerGateway/Dockerfile (1)

53-54: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Verify that dash is executable, not merely present.

test -f allows a non-executable regular file to pass, while localxpose-entrypoint.sh invokes /usr/bin/dash as its shebang interpreter. Use test -x to validate the actual runtime requirement.

Proposed fix
-    && test -f /usr/bin/dash \
+    && test -x /usr/bin/dash \
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Workers/Resgrid.TrackerGateway/Dockerfile` around lines 53 - 54, Update the
Dockerfile validation after installing dash to use an executable-file check for
/usr/bin/dash instead of only checking that it exists, ensuring the interpreter
invoked by localxpose-entrypoint.sh is runnable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Workers/Resgrid.TrackerGateway/Dockerfile`:
- Around line 53-54: Update the Dockerfile validation after installing dash to
use an executable-file check for /usr/bin/dash instead of only checking that it
exists, ensuring the interpreter invoked by localxpose-entrypoint.sh is
runnable.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fc91ed95-d869-4e4a-a60b-3e574fecae7d

📥 Commits

Reviewing files that changed from the base of the PR and between 9bc4417 and cba6898.

📒 Files selected for processing (1)
  • Workers/Resgrid.TrackerGateway/Dockerfile

@ucswift
ucswift merged commit 226cbc9 into master Jul 28, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants