Add optional sinceYear to IAreaReference for rolling-archive append l… - #1
Open
andrewcottam wants to merge 1 commit into
Open
andrewcottam wants to merge 1 commit into
andrewcottam wants to merge 1 commit into
Conversation
…ogic Lets a calculation resume from a given year instead of recomputing its full history -- first consumer is Net Primary Productivity (ModisNPPCalculations.ts in restor2-gee-integration), prototyped and verified there against a local AreaReferenceWithSinceYear cast. This adds the field to the real, published type so that cast can be dropped. Optional and additive, so this is backwards compatible for every existing caller. dist/src/insights.d.ts is hand-updated to match (rather than a full tsc rebuild, to avoid unrelated compiler-version noise across the rest of dist/); dist/src/insights.js is unchanged since interface fields are compile-time only and emit no JS. Version bumped 1.9.3 -> 1.9.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sinceYear?: numberfield toIAreaReference(src/insights.ts), so a calculation request can say "resume from this year" instead of always recomputing full history.ModisNPPCalculations.tsinrestor2-gee-integration), prototyped and verified locally against a localAreaReferenceWithSinceYeartype-augmentation cast — this PR replaces the need for that cast with the real, published field.IAreaReference.dist/src/insights.d.tsis hand-updated to match the source change (rather than a fulltscrebuild, to avoid unrelated compiler-version noise across the rest ofdist/).dist/src/insights.jsis unchanged, since interface fields are compile-time only and emit no JS.1.9.3→1.9.4.Part of the Year-Series Append Plan (rolling-archive calculations -- NDVI, Net Primary Productivity, Evapotranspiration -- appending only new years instead of recomputing history). NPP is first; this is the shared-package piece that unblocks it.
Test plan