feat(proto): add SessionError to the compass.v1 session-trace contract (RIG-2616 T1) - #846
Open
rigel-mintaka wants to merge 1 commit into
Open
feat(proto): add SessionError to the compass.v1 session-trace contract (RIG-2616 T1)#846rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
…t (RIG-2616 T1) Append a dedicated SessionError message + SessionErrorKind enum (ERROR | ABORTED) to the SessionEvent oneof (field 10, non-breaking append) so a pre-stream/inner failure or a deliberate abort can surface as typed session-trace content rather than a bare status frame. Regenerate the three checked-in gen trees (go/gen, compass-client, compass-agent via --include-imports); drift-clean. T1 of the frozen error/abort surfacing contract (docs/designs/agent/compass-agent-error-abort-surfacing/design.md). The mapper emit rule + frame-sink never-drop routing that consume these symbols land in T2. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-agent-rig-3209-sessi.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainAppend a dedicated SessionError message + SessionErrorKind enum (ERROR |
ABORTED) to the SessionEvent oneof (field 10, non-breaking append) so a
pre-stream/inner failure or a deliberate abort can surface as typed
session-trace content rather than a bare status frame. Regenerate the three
checked-in gen trees (go/gen, compass-client, compass-agent via
--include-imports); drift-clean.
T1 of the frozen error/abort surfacing contract
(docs/designs/agent/compass-agent-error-abort-surfacing/design.md). The mapper
emit rule + frame-sink never-drop routing that consume these symbols land in T2.
Co-authored-by: Matt Wilkinson matt@rigel.build