Skip to content

fix(ci): normalize ../RimMind-Core workspace alias and include Directory.Build.props for standalone CI #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcocdaa merged 1 commit into from
Nov 7, 2026
Merged

fix(ci): normalize ../RimMind-Core workspace alias and include Directory.Build.props for standalone CI #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ jobs:
- name: Checkout Code
uses: actions/checkout@v7

- name: Normalize Workspace Directory Alias
run: |
if [ ! -e "../RimMind-Core" ]; then
ln -s "$GITHUB_WORKSPACE" "../RimMind-Core"
fi

- name: Setup .NET
uses: actions/setup-dotnet@v6
with:
Expand Down
9 changes: 9 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project>
<PropertyGroup>
<LangVersion Condition="'$(LangVersion)' == ''">10.0</LangVersion>
<Nullable Condition="'$(Nullable)' == ''">enable</Nullable>
<Deterministic>true</Deterministic>
<RestoreIgnoreFailedSources>true</RestoreIgnoreFailedSources>
<RestoreSources Condition="'$(RestoreSources)' == '' and Exists('$(UserProfile)\.nuget\packages\krafs.rimworld.ref')">$(UserProfile)\.nuget\packages</RestoreSources>
</PropertyGroup>
</Project>
4 changes: 4 additions & 0 deletions Tests/Contracts/P6ApiVersionContracts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ public void DirectoryBuildProps_standardizes_compiler_defaults_without_overridin
{
string repoRoot = FindRepositoryRoot();
string propsPath = Path.Combine(repoRoot, "Directory.Build.props");
if (!File.Exists(propsPath))
{
propsPath = Path.Combine(repoRoot, "RimMind-Core", "Directory.Build.props");
}

ContractCaseRunner.Run(
("Directory.Build.props exists at repository root and sets conditional C# 10, Nullable, and Deterministic defaults", () =>
Expand Down
Loading