Conversation
|
Maybe I think the PR is overkill. If anything this should have been an issue, now I'm thinking it was such a minor thing to mention, since I ended up just forking your project and modifying |
|
Most raylib docs use "raylib.h". I'm fine with either/both tho. What additions did you make to cute_aseprite? Anything we should include here? I'm sure there's been some updates to cute lately we could bring in. |
|
Yeah, now that I think about it it shouldn't be a big deal. I was probably too tired to think about it too clearly when I opened this issue. Altho the thing of allowing users to use a modified header of What I did in my local fork is first of all modify And secondly (I didn't finish testing it yet in all the cases, but will do tomorrow, I'm going to sleep for now) I added support for the Tag Repeat option ( By the way, I was thinking a |
|
Should I close this PR? It's a little bit nonsense now |
|
We can bring your cute changes in here, no problem. Would that help? |
|
That could be useful to me. I'm opening a new PR with my tags rework and you tell me what you like and what you don't |
I wanted to fork
cute_asepriteon my project, so I had to also fork your repository to change local (quoted) include directive so it used angle-brackets instead. This way, my compiler would find MY forked definition of the library first, according to my CMake configuration.I think it would be useful to allow the user to use their own implementation. But the real reason I'm proposing this change instead of keeping my changes for me is because I believe it would make more sense semantically to use angle-brackets for external dependencies. What are your thoughts on this?