Skip to content

Use angle-bracket include for libraries includes - #33

Open
Pituivan wants to merge 1 commit into
RobLoach:masterfrom
Pituivan:use-angle-brackets
Open

Pituivan wants to merge 1 commit into
RobLoach:masterfrom
Pituivan:use-angle-brackets

Conversation

@Pituivan

@Pituivan Pituivan commented Sep 11, 2026 •

Copy link
Copy Markdown

I wanted to fork cute_aseprite on my project, so I had to also fork your repository to change local (quoted) include directive so it used angle-brackets instead. This way, my compiler would find MY forked definition of the library first, according to my CMake configuration.

I think it would be useful to allow the user to use their own implementation. But the real reason I'm proposing this change instead of keeping my changes for me is because I believe it would make more sense semantically to use angle-brackets for external dependencies. What are your thoughts on this?

@Pituivan

Copy link
Copy Markdown
Author

Maybe cute_aseprite.h is fine as quoted include because it's technically a local file.

I think the PR is overkill. If anything this should have been an issue, now I'm thinking it was such a minor thing to mention, since I ended up just forking your project and modifying cute_aseprite.h in my fork

@RobLoach

Copy link
Copy Markdown
Owner

Most raylib docs use "raylib.h". I'm fine with either/both tho.

What additions did you make to cute_aseprite? Anything we should include here? I'm sure there's been some updates to cute lately we could bring in.

@Pituivan

Pituivan commented Sep 12, 2026 •

Copy link
Copy Markdown
Author

Yeah, now that I think about it it shouldn't be a big deal. I was probably too tired to think about it too clearly when I opened this issue.

Altho the thing of allowing users to use a modified header of cute_aseprite.h is still worth imo. But keeping the quotes also wouldn't bother me.

What I did in my local fork is first of all modify ase_animation_direction_t enum so its values reflect actual Aseprite options (see my PR RandyGaul/cute_headers#444). Since this change added the Ping-pong Reverse option, I just implemented it in your library.

And secondly (I didn't finish testing it yet in all the cases, but will do tomorrow, I'm going to sleep for now) I added support for the Tag Repeat option (tag.repeat in cute_headers) so non-looping animations play repeat times before finishing (pausing).

By the way, I was thinking a PlayAnimation or PlayTag basic function could be nice, since I found manually setting .pause = false to non-looping tags just to play them to be a little bit awkward.

@Pituivan

Copy link
Copy Markdown
Author

Should I close this PR? It's a little bit nonsense now

@RobLoach

Copy link
Copy Markdown
Owner

We can bring your cute changes in here, no problem. Would that help?

@Pituivan

Copy link
Copy Markdown
Author

That could be useful to me. I'm opening a new PR with my tags rework and you tell me what you like and what you don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants