docs: fix broken "How to use" links in payment methods - #2633
Conversation
Point all four to the rendered site pages (/read/en/, /read/es/, /read/fr/) instead of GitHub blob URLs. The tutorials reference their screenshots with site-absolute paths (/assets/images/how-to-use/...), so a blob link would render the page with every image broken. pt falls back to /read/en/ as there is no Portuguese tutorial. Also fix a dead image in the English and French tutorials: the Satoshi's Journal "Robo Garage" header returned 404, as did the article itself. The image is now vendored under assets/images/how-to-use/ and the article links to its Wayback snapshot. Closes RoboSats#2620
1193dcd to
64e70f4
Compare
KoalaSat
left a comment
There was a problem hiding this comment.
Ey @21Mill thanks for the PR! I was thinking maybe we should switch to another available video instead or relaying in the Internet Archive (with services down by the time I write this 😅
I would say the one still valid and widely used is https://www.youtube.com/watch?v=XW_wzRz_BDI
|
The Internet Archive thing makes sense. but the image itself is no longer served from archive.org. I vendored it into The video is already embedded at
I'd lean towards 1, since it removes the archive.org link entirely without duplicating content. Let me know and I'll push the change. |
What does this PR do?
Fixes #2620
The "How to use" link on the payment methods pages pointed to
docs/how-to-use.md,a file that no longer exists, so it returned a GitHub 404. While fixing it I found
the three translations were broken as well:
01-best-practices/02-payment-methods.mdblob/main/docs/how-to-use.md— 404 (the reported one)/read/en/fr/…blob/main/docs/fr/how-to-use.md— 404 too/read/fr/es/…Robosats)/read/es/pt/…/read/en/They now point at the rendered site pages rather than GitHub blob URLs. That matters
beyond the 404: the tutorials reference their screenshots with site-absolute paths
(
/assets/images/how-to-use/…), which the blob view resolves againstgithub.com,so a blob link would land the reader on a page with every screenshot broken. The
permalinks used here (
/read/en/,/read/es/,/read/fr/) are the same ones thesidebar navigation already uses.
ptfalls back to/read/en/because there is noPortuguese tutorial.
Also fixed a dead image while in there: the Satoshi's Journal "Robo Garage" header in
the English and French tutorials (
i0.wp.com/satoshisjournal.com/…/robosats.jpg)returns 404, and so does the linked article — it is gone from the site entirely, not
just moved. The image is now vendored under
assets/images/how-to-use/(recoveredfrom the Wayback snapshot, 814×458, 96K) and the article link points at its Wayback
snapshot so the reference stays usable.
Verified: all 32 local image paths referenced by the tutorials resolve to files in the
repo, the three target permalinks exist, and no reference to
i0.wp.comremains.Not included:
_data/navigation_pt.yml:100links to/read/pt/, which does not existeither — happy to fold that in or leave it for a separate PR.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installsgit hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.