Skip to content

chore(sidebar): tighten Extended room list item layout#41479

Draft
dougfabris wants to merge 1 commit into
developfrom
chore/sidebar-room-list-view-mode
Draft

chore(sidebar): tighten Extended room list item layout#41479
dougfabris wants to merge 1 commit into
developfrom
chore/sidebar-room-list-view-mode

Conversation

@dougfabris

@dougfabris dougfabris commented Jul 20, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Refines the Extended sidebar item to a more compact layout:

  • Moves the avatar into the title row (alongside icon and title) instead of sitting as a separate leading column
  • Nests the item at level 2 and reduces its avatar to x20 (from x36)
  • Applies the unread state to the timestamp so it matches the title

Issue(s)

Steps to test or reproduce

Further comments

Review in cubic

@dionisio-bot

dionisio-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 8.8.0, but it targets 8.7.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b7b50e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19d1fe2d-1c1e-4ab0-9aac-2457408443fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dougfabris dougfabris modified the milestones: 8.8.0, 9.0.0 Jul 20, 2026
@dougfabris
dougfabris force-pushed the chore/sidebar-room-list-view-mode branch from c2f8f35 to 8b7b50e Compare July 20, 2026 17:20
@dougfabris dougfabris changed the title chore(sidebar): Consolidate room list view modes into Compact and Detailed chore(sidebar): tighten Extended room list item layout Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.60%. Comparing base (3240cdb) to head (8b7b50e).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41479      +/-   ##
===========================================
- Coverage    68.61%   68.60%   -0.02%     
===========================================
  Files         4134     4134              
  Lines       160801   160803       +2     
  Branches     29289    29274      -15     
===========================================
- Hits        110327   110311      -16     
- Misses       45371    45387      +16     
- Partials      5103     5105       +2     
Flag Coverage Δ
e2e 58.84% <100.00%> (-0.13%) ⬇️
e2e-api 45.60% <ø> (+0.26%) ⬆️
unit 70.54% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant