Skip to content

regression: secondary sidebar item adjustments after the Item migration - #42901

Merged
ggazzo merged 2 commits into
developfrom
fix/secondary-sidebar-item-spacing
Oct 19, 2026
Merged

ggazzo merged 2 commits into
developfrom
fix/secondary-sidebar-item-spacing

Conversation

@juliajforesti

@juliajforesti juliajforesti commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

ARCH-2499
Fixes layout regressions in the secondary sidebar feature preview introduced by #42819:

  • Rows did not reach the edges of the list. The row wrapper and the filter tablists added paddingInline={4}, so the hover and selected surfaces stopped short of the edges and read as pills. The padding is removed.
  • Filters were misaligned with the rooms and group headers. The filters rendered a bare Item without an inset, while rooms and group headers use the md inset. They now render SidebarItem, so all rows share the same inset. The filter dividers follow that inset (marginInline={12}).
  • The sticky group header was transparent. Before the migration the collapse group bar carried the sidebar surface; the Item group header does not, so rooms scrolling under the pinned header showed through it. The virtualized group wrapper now takes surface-sidebar.

All changes live in the application, under the feature preview's RoomList; Fuselage and other SidebarItem consumers are untouched.

Issue(s)

Regression from #42819 (unreleased), so no changeset.

Steps to test or reproduce

  1. Enable the secondary sidebar feature preview.
  2. Hover and select rooms and filters (All, Favorites, Discussions, omnichannel filters): the surface fills the full row width.
  3. Check that filter icons, group headers and room avatars line up.
  4. Scroll the room list: the pinned group header stays opaque over the rooms passing beneath it.

Further comments

🤖 Generated with Claude Code

View guided diff

juliajforesti and others added 2 commits October 19, 2026 10:30
…debar

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dionisio-bot

dionisio-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juliajforesti juliajforesti changed the title regression: secondary sidebar item spacing and sticky group header after the Item migration regression: secondary sidebar item adjustments after the Item migration Oct 19, 2026
@ggazzo ggazzo added this to the 8.10.0 milestone Oct 19, 2026
@ggazzo
ggazzo marked this pull request as ready for review October 19, 2026 13:40
@ggazzo
ggazzo requested a review from a team as a code owner October 19, 2026 13:40
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.73%. Comparing base (d7dc383) to head (aebb414).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #42901   +/-   ##
========================================
  Coverage    70.73%   70.73%           
========================================
  Files         5424     5423    -1     
  Lines       230979   230979           
  Branches     42082    42080    -2     
========================================
+ Hits        163381   163391   +10     
+ Misses       62291    62273   -18     
- Partials      5307     5315    +8     
Flag Coverage Δ
e2e 58.90% <100.00%> (-0.04%) ⬇️
e2e-api 45.90% <ø> (-0.03%) ⬇️
unit 71.28% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

View guided diff | Re-trigger cubic

@juliajforesti juliajforesti added the preview Builds a UI preview that Rocket.Chat Desktop can load label Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

🖥️ UI preview

Removed from ghcr.io/rocketchat/rocket.chat-web. Add the preview label again to publish a new one.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 19, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 19, 2026
@ggazzo
ggazzo merged commit 9e8f070 into develop Oct 19, 2026
68 checks passed
@ggazzo
ggazzo deleted the fix/secondary-sidebar-item-spacing branch October 19, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Builds a UI preview that Rocket.Chat Desktop can load stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants