Repository navigation
regression: secondary sidebar item adjustments after the Item migration - #42901
Conversation
…debar Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Looks like this PR is ready to merge! 🎉 |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Item migrationItem migration
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42901 +/- ##
========================================
Coverage 70.73% 70.73%
========================================
Files 5424 5423 -1
Lines 230979 230979
Branches 42082 42080 -2
========================================
+ Hits 163381 163391 +10
+ Misses 62291 62273 -18
- Partials 5307 5315 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🖥️ UI previewRemoved from |
Proposed changes (including videos or screenshots)
ARCH-2499
Fixes layout regressions in the secondary sidebar feature preview introduced by #42819:
paddingInline={4}, so the hover and selected surfaces stopped short of the edges and read as pills. The padding is removed.Itemwithout an inset, while rooms and group headers use themdinset. They now renderSidebarItem, so all rows share the same inset. The filter dividers follow that inset (marginInline={12}).Itemgroup header does not, so rooms scrolling under the pinned header showed through it. The virtualized group wrapper now takessurface-sidebar.All changes live in the application, under the feature preview's
RoomList; Fuselage and otherSidebarItemconsumers are untouched.Issue(s)
Regression from #42819 (unreleased), so no changeset.
Steps to test or reproduce
Further comments
🤖 Generated with Claude Code