Repository navigation
regression: user menu avatar clipped by the section header - #42967
Conversation
…on header The user menu header sits in an `ItemGroupTitle`, which hides overflow. The negative block margins that offset the old `OptionTitle` padding pushed the avatar past its top edge, cutting its rounded corners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Looks like this PR is ready to merge! 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThe outer ChangesUser menu layout
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the user menu avatar clipping regression, which is the primary change addressed by removing the negative margins. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
- Commit to this branch
- Create a new PR
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #42967 +/- ##
===========================================
+ Coverage 70.96% 71.00% +0.03%
===========================================
Files 5426 5426
Lines 231296 231655 +359
Branches 42275 42334 +59
===========================================
+ Hits 164133 164480 +347
- Misses 61867 61878 +11
- Partials 5296 5297 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ggazzo
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
Proposed changes (including videos or screenshots)
ARCH-2572
Since #42818, the menu renders section titles with
ItemGroupHeaderandItemGroupTitleinstead ofOptionTitle.ItemGroupTitlehides overflow. The user menu header still had negative block margins (-8pxtop,-4pxbottom) that cancelled the oldOptionTitlepadding. Those margins pushed the avatar past the top of the title, so its top edge and rounded corners were cut off and the avatar looked square.This PR removes those margins. The avatar now keeps its 36px rounded shape, and its inline offset is still 12px. The header now has the new group header's 4px block padding, so it sits 4px lower and has 4px more space below than before #42818.
Issue(s)
Regression from #42818. That change hasn't shipped in a release yet, so this PR has no changeset.
Steps to test or reproduce
Further comments
The migration also changed the display name's color from the default text color to the group header's secondary text color. This PR leaves that as is.
🤖 Generated with Claude Code
Summary by CodeRabbit