Repository navigation
fix(fuselage-hooks): handle storage clear events - #2264
Open
YashAnand69 wants to merge 1 commit into
Open
YashAnand69 wants to merge 1 commit into
YashAnand69 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c58cdc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Handle cross-document storage.clear() events in useStorage. These events have a null key; the hook previously filtered them out and left consumers with stale values. The existing fallback and notification path now runs after confirming the storage area.
Issue(s)
Closes #2263. Independent of #2242, which handles switching the hook's key or storage area.
Further comments
Three clear-event regressions fail before the fix; the unrelated-storage isolation case passes. After the change, all 51 fuselage-hooks suites / 143 tests pass, as do package lint, TypeScript, formatting and diff checks. Coverage includes local and session storage, other-area isolation and the latest fallback. Events are simulated; no multi-tab browser end-to-end test was run. No public API change. Includes a patch changeset. AI-assisted implementation and validation.