fix(fuselage-hooks): react to position option changes - #2268
Open
YashAnand69 wants to merge 1 commit into
Open
YashAnand69 wants to merge 1 commit into
YashAnand69 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4d8da3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Recalculate overlay placement when placement or margin props change. When the container changes, reattach observation to the replacement element so the next measurement uses its geometry.
Issue(s)
Closes #2267. Independent of #2260 (document scroll) and #2266 (fallback coordinate mapping).
Further comments
Three hook regressions fail before the fix and pass afterward: placement update, margin update and replacement-container observation. All 51 hooks suites / 142 tests pass, as do package lint, TypeScript, formatting and diff checks. Uses existing debounced measurement, with no new API or dependency. Geometry and observer tests are simulated; browser visual regression was not run. Includes a patch changeset. AI-assisted implementation and validation.