Optimize Dataset sort() - #431
Open
andrewdalpino wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces Dataset::sort()’s O(n²) bubble sort with PHP’s native usort()-based approach to improve sorting performance on large datasets, and updates the dataset sorting benchmark to cover multiple dataset sizes.
Changes:
- Replaced the manual bubble sort in
Rubix\ML\Datasets\Dataset::sort()with ausort()comparator wrapper. - Updated
SortingBenchto benchmark multiple dataset sizes via PhpBench parameter providers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Datasets/Dataset.php | Switches dataset sorting implementation from bubble sort to usort() for O(n log n) behavior. |
| benchmarks/Datasets/SortingBench.php | Expands the benchmark to run sorting across multiple dataset sizes using param providers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@andrewdalpino do we need this file in repo: runtime/test-results ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset::sort() is an O(n²) bubble sort — confirmed at src/Datasets/Dataset.php:441-459. Switch to native usort() (Timsort, O(n log n), C-implemented). 10–100× for n > ~1000.
Targetting 3.0 branch as this changes the operation from an exact sort to an unstable sort.