test: UserStampService 유닛 테스트 + Redis 보안 설정 반영 (prod) - #235
Merged
Conversation
dev에서 검증 완료된 UserStampServiceTest(스탬프 생성/레벨업 로직 17개 테스트)와 RedisConfig의 비밀번호/SSL/타임아웃 설정을 main에 반영한다. 비밀번호/SSL은 spring.data.redis.password, spring.data.redis.ssl.enabled 값이 없으면 기존과 동일하게 동작하도록 기본값을 뒀다 — 운영 환경에 해당 값을 채워야 실제로 적용된다.
unam98
requested review from
RinRinPARK,
YuSuhwa-ve and
funnysunny08
as code owners
August 11, 2026 07:24
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 배경
dev/main 컨텐츠 정합성 점검의 마지막 단계. dev에서 이미 검증된 UserStampService 유닛 테스트와, Redis 연결에 비밀번호/SSL/타임아웃을 지원하도록 한 보안 강화가 main엔 반영되어 있지 않았다.
변경 사항
config/redis/RedisConfig.javaspring.data.redis.password/ssl.enabled값 지원 추가, 커넥션/커맨드 타임아웃 30초로 명시 설정user/service/UserStampServiceTest.java(신규)영향 범위
RedisConfig: password/ssl 값은 기본값(빈 문자열/false)이라 값을 설정하지 않으면 기존과 동일하게 동작 — 운영 환경에 실제로 반영하려면spring.data.redis.password/ssl.enabled값을 채워야 함.검증 매트릭스
createStampByUser 테스트 그룹스탬프_4개면_레벨업외findUserStamps 테스트 그룹Test Plan
./gradlew test전체 251/251 통과🤖 Generated with Claude Code