Remove Null host - #1386
Open
Marco-Farruggio wants to merge 2 commits into
Open
Remove Null host#1386Marco-Farruggio wants to merge 2 commits into
Marco-Farruggio wants to merge 2 commits into
Conversation
Contributor
Author
|
Related: I think #571 can be closed because WASI doesn't support audio, and the proposed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the null host, add a compilation error on unsupported targets, and updated the documentation. To me expecting cpal to compile on a target with no audio capabilities is like expecting a GUI library to compile on a target with no display server, which should really be a build error. This also means its less clutter in the codebase which is always a plus.
Closes #1366