Repository navigation
ci: pin actions by SHA, add concurrency and job timeouts - #12
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Phase 1 CI cleanup. 35 action references were mutable tags and 11 jobs had no
timeout-minutes;ci.ymlhad noconcurrency.Change
ci.yml:concurrencycancels a superseded PR run only (cancel-in-progressis true forpull_request, false for pushes to main, so a main run is never cut short).timeout-minutes: 15on its 5 jobs (observed whole-run max 11.4 min).release.yml:timeout-minutes: 45on its 6 jobs (observed whole-run max 8.8 min). Noconcurrency, deliberately:cancelling a tag release mid-publish would be harmful. Its triggers are
v*tags and manual dispatch only, and its macOSmatrix is release-only, so there is nothing to cut there.
git ls-remoteagainst the public action repos.dtolnay/rust-toolchaintook its Rust version from the ref name (@stable). A SHA has no such name, so I addedwith: toolchain: stableto all three uses to keep the same behavior.Estimate
No estimate: this repo billed $0 for Nov 1-12 (free or included minutes), so this is hygiene, not a cost fix. 42 recent CI runs, median 4.2 min.
Not verified
Actions is blocked on the account until Dec 1 (spending cap), so CI has not run on this change. YAML was parsed locally
and every job was checked for a timeout and every
uses:for a full-SHA pin;actionlintis not installed. Job andcheck names are unchanged, so existing required checks keep their names.
🤖 Generated with Claude Code