Address presentation feedback: submitted-SCV corpus, benchmark rework, cleaning rules, positional drift - #125
Merged
Merged
Conversation
…s, positional drift)
Run the exact inject_and_clean.py corpus (3,419 cases) through the LOVD HGVS syntax checker (v1.2.2, local PHP CLI) and clean_hgvs(), scored identically (gene-annotation-insensitive exact match to the canonical target). Weighted by the production error mix LOVD's top-ranked correction recovers 71.7% vs 100% (by construction) for clean_hgvs(); neither tool alters a valid input. New lovd_comparison Snakefile rule with frozen-constants fallback, facts CSV, and Methods/Discussion prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responds to all seven items in the 2026-08-08 presentation feedback plan (the plan file is deleted by this PR now that it is complete).
Client code (CHANGELOG updated)
resolve_missing_accession_prefix()that restores a droppedNM_/XM_/NR_/XR_prefix only when exactly one candidate exists in the loaded provider. Production corpus: rescued 1,678 to 1,721, residual 1,118 to 1,075, zero regressions. 23 new tests.get_tx_exonscache (Do some benchmarks #5). Bounded per-instance LRU on the per-variant hot path, ~4% throughput gain, correct for lazily fetched REST providers.Paper
build_clinvar_submitted_pairs.pybuilds 2.93M unique lab-submitted (AlleleID, HGVS) pairs from the VCV release. 81.8% cite a superseded transcript version; cdot holds 99.3% of those. On a seeded 3,000 sample cdot resolves 98.9% vs UTA 80.1% (the old current-version corpus is kept as an explicit ceiling row). Public residual taxonomy shows failures are version age, not formatting.Full test suite: 407 passed, 5 skipped. Paper quick build renders with all facts substituted.
🤖 Generated with Claude Code
https://claude.ai/code/session_015662nbf1iezxdL9EMcckU7