Conversation
R1 correctness fixes: - vscode-deps-upgrade-tool: move @types/fs-extra to devDependencies - vscode-mta-tools: pin @vscode-logging/logger to workspace:* - vscode-webview-rpc-lib: pin @vscode-logging/types to workspace:* - yeoman-ui backend: raise @types/vscode to ^1.100.0 to match engines - guided-development backend: add missing @types/vscode R3 version dedup: - websocket unified to 1.0.35 - sinon unified to 18.0.1 (test-only devDep) - fs-extra unified to 11.3.0 / @types/fs-extra to 11.0.4 The @types/fs-extra bump changes readFile's overload typing; convert three cfutil.spec.ts stubs to sinon .resolves/.rejects to compile.
pnpm resolves the workspace from pnpm-workspace.yaml, which already carries the identical package globs. The package.json "workspaces" key was only being read by @manypkg/get-packages (used by changesets), which mis-detected the repo as Yarn. Removing it lets manypkg fall through to pnpm detection. Verified pnpm (62 projects), manypkg (now tool: pnpm), and changeset status all still resolve.
Under pnpm 11 (.npmrc is auth/registry-only), both settings were no longer read: strict-peer-dependencies=false equals the pnpm 11 default, and auto-install-peers=false was dormant (the tree resolves peers as if the default true). Neither ported to pnpm-workspace.yaml.
Contributor
Build ReportPlease note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
1. Dependency metadata fixes & version dedup (
27d5006)Correctness fixes:
vscode-deps-upgrade-tool: move@types/fs-extratodevDependenciesvscode-mta-tools: pin@vscode-logging/loggertoworkspace:*vscode-webview-rpc-lib: pin@vscode-logging/typestoworkspace:*yeoman-uibackend: raise@types/vscodeto^1.100.0to matchenginesguided-developmentbackend: add missing@types/vscodeVersion dedup across the workspace:
websocket→1.0.35sinon→18.0.1(test-only devDep)fs-extra→11.3.0/@types/fs-extra→11.0.4The
@types/fs-extrabump changedreadFile's overload typing, so threecfutil.spec.tsstubs were converted to sinon.resolves/.rejectsto keep compiling.2. Remove redundant Yarn-format
workspacesblock from rootpackage.json(021ea13)pnpm resolves the workspace from
pnpm-workspace.yaml, which already carries the identical package globs. Thepackage.json"workspaces"key was only read by@manypkg/get-packages(used by changesets), which mis-detected the repo as Yarn. Removing it lets manypkg fall through to pnpm detection.3. Remove
.npmrc(85a6667)Under pnpm 11 (
packageManager: pnpm@11.1.1),.npmrcis auth/registry-only; its two behavioral settings were no longer being read.strict-peer-dependencies=falseequals the pnpm 11 default.auto-install-peers=falsewas dormant — the tree has been resolving peers as if the defaulttrue, so it was intentionally not ported topnpm-workspace.yaml.Why
Removes stale/dead config that no longer has any effect under pnpm 11 and could mislead readers or tooling (manypkg mis-detecting Yarn). Deduping versions and correcting dependency placement keeps the lockfile lean and metadata accurate.
Notes for reviewers
autoInstallPeers: falseinpnpm-workspace.yaml(expect lockfile churn: ~5 added /~75 removed).tool: pnpm, andchangeset statusstill resolves.