chore(gitignore): ignore tsc build info and task-explorer dummy output - #629
Merged
Merged
Conversation
The release workflow builds before running the changesets step, and the changesets action commits the working tree, so untracked build output leaks into the version PR. Widen the tsc artifact ignore to *.tsbuildinfo and ignore task-explorer's generated dummy webpack output. Signed-off-by: Jacob Kreyenbuehl <jacob.kreyenbuehl@sap.com>
Contributor
Build ReportPlease note:
|
rolanbadrislamov
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen two
.gitignorerules so build output stops leaking into the Changesets version PR:tsconfig.tsbuildinfo->*.tsbuildinfo(the exact-name rule missedtsconfig.browser/ext/test.tsbuildinfo).projects/task-explorer/packages/tasks_panel/dummy/(webpack output ofsrc/dummy.js, used only to copy the frontend files).Why
release.ymlrunspnpm run ci(a full build) before the Changesets step, andchangesets/actioncommits the working tree. Any untracked, not-ignored build output therefore lands in the version PR. On the current version PR (#625) this produced:projects/vscode-webview-rpc-lib/tsconfig.{browser,ext,test}.tsbuildinfoprojects/task-explorer/packages/tasks_panel/dummy/main.jsThese are machine-generated and should never be committed. No prior version PR had them; they appeared once those packages were migrated.
Note (deliberately not changed)
The version PR also picks up a generated
projects/task-explorer/packages/tasks_panel/LICENSE(created byscripts/legal-copy.js). I left that alone on purpose: the root.gitignoreintentionally un-ignores nestedLICENSEfiles, and several packages (e.g.packages/app-studio-toolkit/LICENSE) do track one. So whether the generated copy should be committed is a separate call, not obviously a bug.Behaviour
No code change. Verified with
git check-ignore: the four artifact paths are now ignored, and nestedLICENSEfiles remain trackable.