Skip to content

Rewrite implementation of FastF1 API? #203

Description

@pbulsink

I'm wondering if in the off-season we expand/rewrite some of the capabilities of f1dataR to match the new capabilities of FastF1, and also be more capable of implementing changes to reflect the changes there (#198).

For example, right now, for us to add and fully use pick_drivers instead of using pick_driver takes a rewrite of our get_session_laps() (#78). Had pick_driver() instead been a standalone function (as part of a class or otherwise) it'd be much easier to just accept a vector of character strings or numbers instead of a single value.

I also wonder if having an interface that more closely matches the workflow of FastF1 will make it easier for people to duplicate or expand on analysis they otherwise see happening in Python?

Thoughts?

Activity

  1. SCasanova commented on Nov 12, 2023

    @SCasanova
    Owner

    I'm al for it. To be honest the original implementations didn't have much though put into it and I didn't know what the package would turn into. Big fan of rewriting old code

  2. Repository owner locked and limited conversation to collaborators on Nov 13, 2023
  3. converted this issue into a discussion #206 on Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions