Repository navigation
Perf/UUID serializer - #441
Merged
Merged
Conversation
… input length - replace ByteBuffer.wrap with a big-endian byteArrayViewVarHandle for packing and unpacking the UUID halves; the bytes written are unchanged - reject decoded byte arrays that are not exactly 16 bytes long with an IllegalArgumentException instead of a BufferUnderflowException or silent truncation - give the descriptor its own serial name "surf.api.UUID" instead of reusing the ByteArray descriptor
- serialize UUID as a structure of two long elements "most" and "least" - add SerializableLongUUID typealias - decode elements in any order and fail with SerializationException when one is missing - update ABI dump for surf-api-core
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.